Fix 1338 main #1344
Fix 1338 main #1344
Conversation
Configure Renovate
| @@ -43,13 +43,14 @@ public ConfigData load(ConfigDataLoaderContext context, KubernetesConfigDataReso | |||
| ConfigurableBootstrapContext bootstrapContext = context.getBootstrapContext(); | |||
| Environment env = resource.getEnvironment(); | |||
|
|
|||
| if (bootstrapContext.isRegistered(ConfigMapPropertySourceLocator.class)) { | |||
There was a problem hiding this comment.
this is an interesting change right here. For config data, we need to provide the sources in the order we want, looks like @Order is not respected. The documentation of ConfigData constructor is a bit interesting:
propertySources - the config data property sources in ascending priority order.
I assume it means we need to provide the proper order to it, but it accepts a Collection as input; which can be a Set, for example... which has no order. I would have expected a List here; but then again a LinkedHashSet is ordered too, tricky!
Sequenced collections would be a great addition to these kind of APIs.
There was a problem hiding this comment.
This is the only important change, everything else are just tests. I had to adjust them a little, cause in the main branch - we have two types of tests : bootstrap and config data. Functionally, the tests have not changed at all.
|
@ryanjbaxter ready. fixes the current build + add some config data tests for the issues we did yesterday on the |
|
Thanks! |
No description provided.