Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1405 #1406

Merged
merged 44 commits into from
Aug 10, 2023
Merged

Fix 1405 #1406

merged 44 commits into from
Aug 10, 2023

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Aug 8, 2023

No description provided.

@wind57 wind57 marked this pull request as ready for review August 9, 2023 08:45
@wind57
Copy link
Contributor Author

wind57 commented Aug 10, 2023

this is ready to be looked at too @ryanjbaxter. previous builds are failing, but there is not much to do there, just a re-trigger or a merge of a new PR on top of those.

@ryanjbaxter
Copy link
Contributor

I assume you meant that this fixes #1405 not #1045, right?

@wind57 wind57 changed the title Fix 1045 Fix 1405 Aug 10, 2023
@wind57
Copy link
Contributor Author

wind57 commented Aug 10, 2023

ups! you're right, edited

@ryanjbaxter
Copy link
Contributor

We are in the middle of a release so I will merge this once that finishes, thanks

@ryanjbaxter ryanjbaxter merged commit cea5b8e into spring-cloud:3.0.x Aug 10, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Metadata differs in fabric8 and k8s client in some corner case
3 participants