fix current main build failure #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wind57
commented
Oct 7, 2023
| @@ -91,6 +91,7 @@ static void beforeAll() throws Exception { | |||
|
|
|||
| @AfterAll | |||
| static void afterAll() throws Exception { | |||
| util.deleteNamespace("istio-system"); | |||
There was a problem hiding this comment.
this is needed to fix failures in the main branch, what happens there is:
Fabric8IstioITruns, does not clean after itself, leaves a service running inistio-systemnamespaceKubernetesClientDiscoveryClientITruns after it, and searches for services in all namespaces. It expects to find only services defined in its set-up, but also find the one from the previous integration test and fails the assertions.
We did not had until now such a distribution in integration tests so that we could catch this. This is a bug
|
@ryanjbaxter this fixes our current main failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.