Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric8 it part 8 #1475

Merged
merged 48 commits into from
Oct 9, 2023
Merged

Fabric8 it part 8 #1475

merged 48 commits into from
Oct 9, 2023

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Oct 8, 2023

No description provided.

@wind57
Copy link
Contributor Author

wind57 commented Oct 8, 2023

this has been sitting on me for far too much, I really want to have homogenized names for our integration tests, this is step one in that direction:

spring-cloud-kubernetes-fabric8-client-catalog-watcher

and

spring-cloud-kubernetes-k8s-client-catalog-watcher

imho, this looks good.

@@ -48,20 +48,20 @@
</dependencyManagement>

<modules>
<module>spring-cloud-kubernetes-fabric8-istio-it</module>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing has changed here, I'm just grouping modules a bit

@wind57 wind57 marked this pull request as ready for review October 9, 2023 19:00
@wind57
Copy link
Contributor Author

wind57 commented Oct 9, 2023

@ryanjbaxter nothing changes functionally, just a way to make easier navigation through integration tests. I'll have a few more PRs like this in this direction and we will soon be able to "close this epic" that had to do with refactoring integration tests. Not there yet, but I can definitely see the finish line. thank you

@ryanjbaxter ryanjbaxter added this to the 3.0.6 milestone Oct 9, 2023
@ryanjbaxter ryanjbaxter merged commit df6fd5c into spring-cloud:3.0.x Oct 9, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants