minor unification of two conditionals #1577
Conversation
| @Documented | ||
| @Inherited | ||
| @ConditionalOnClass(HealthIndicator.class) | ||
| @ConditionalOnCloudPlatform(CloudPlatform.KUBERNETES) |
There was a problem hiding this comment.
unify these two conditionals and use them in every client.
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| @Inherited | ||
| @ConditionalOnClass(name = "org.springframework.boot.actuate.health.HealthIndicator") |
There was a problem hiding this comment.
we can't use @ConditionalOnClass(HealthIndicator.class) since the documentation of ConditionalOnClass::value says:
In order to use this annotation as a meta-annotation, only use the name attribute
We have a test will fail otherwise, and this is how I found out about this doc.
| @@ -36,7 +36,7 @@ | |||
| @Retention(RetentionPolicy.RUNTIME) | |||
| @Documented | |||
| @Inherited | |||
| @ConditionalOnClass({ HealthIndicator.class }) | |||
| @ConditionalOnClass(name = "org.springframework.boot.actuate.health.HealthIndicator") | |||
There was a problem hiding this comment.
piggy back this change in here, now that I know that in composite annotations we must use name and not value
|
@ryanjbaxter need a bit of an explanation on the protected branch... what has changed? thank you. may be I am not making the PR against the correct branch anymore? |
|
Spring Cloud 2022.0.x is out of support so we have blocked all changes against branches of projects for that release train. Only Spring Cloud 2023.0.x is supported so you can only submit PRs to the main branch now. |
|
ok, thank you, this is ready to be looked at. there are 3 changes here:
|
|
P.S. This change to |
|
No we cannot introduce any breaking changes in 2023.0.x |
No description provided.