Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: adding ID Token TTL config #1073

Closed
wants to merge 2 commits into from
Closed

feature: adding ID Token TTL config #1073

wants to merge 2 commits into from

Conversation

ClaudenirFreitas
Copy link

@ClaudenirFreitas ClaudenirFreitas commented Feb 15, 2023 •
edited
Loading

  • adding ID Token TTL config;
  • adding unit tests;
  • improving code coverage;

@ClaudenirFreitas ClaudenirFreitas mentioned this pull request Feb 15, 2023
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 15, 2023
@jgrandja
Copy link
Collaborator

Thank you for the PR @ClaudenirFreitas.

However, the addition of TokenSettings.idTokenTimeToLive will need to be added as part of the feature to be delivered in gh-58.

Please see this comment for additional details.

@jgrandja jgrandja closed this Feb 23, 2023
@jgrandja jgrandja self-assigned this Feb 23, 2023
@jgrandja jgrandja added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgrandja jgrandja

Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClaudenirFreitas @jgrandja @spring-projects-issues