-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origin support for empty YAML list and map #20506
Labels
status: superseded
An issue that has been superseded by another
type: enhancement
A general enhancement
Comments
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Mar 12, 2020
mbhave
added
type: enhancement
A general enhancement
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Mar 12, 2020
mbhave
changed the title
OriginTrackedYamlLoader support emptylist ([]) and emptymap ({})
Add origin support for empty YAML list and map
Mar 12, 2020
unix1982
added a commit
to unix1982/spring-boot
that referenced
this issue
Jun 4, 2020
Add the fix for CollectionNode Add test
Closing in favor of PR #21704. |
It seems that @mbhave intended to close this. |
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: superseded
An issue that has been superseded by another
type: enhancement
A general enhancement
While searching the root cause for spring-cloud/spring-cloud-config#1572 I reviewed
OriginTrackedYamlLoader
. In cases of an empty list or empty map there is no origin created.Reproduction
Add to https://raw.githubusercontent.com/spring-projects/spring-boot/master/spring-boot-project/spring-boot/src/test/resources/org/springframework/boot/env/test-yaml.yml
and extend testcases for emptylist and emptymap.
Fix
Add additional code for CollectionNodes which are empty In
OriginTrackedYamlLoader.constructObject
between ScalarNode and MappingNode check.spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/env/OriginTrackedYamlLoader.java
Lines 85 to 95 in a66c4d3
The text was updated successfully, but these errors were encountered: