Apply spring.pulsar.consumer.subscription.name to auto-configured Pulsar listener container #42067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subscription name config prop was not being set on the Pulsar listener container properties. This commit adds the subscription name to the Pulsar property mappers. Resolves spring-projects#42053
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
|
Should we be treating this as a bug, @onobc? The property and the API to apply it seem to be there in Boot 3.2. Should we apply the change to 3.2.x and later or only to main? |
wilkinsona
added
the
status: waiting-for-internal-feedback
|
My understanding is that this depends on changes Chris did in spring-projects/spring-pulsar#821 meaning this is a 3.4 target. |
|
@vpavic summary is correct. The property is there and still does configure the default consumer factory but the property is ignored when it comes to the message container (i.e. |
|
Thanks, both. |
wilkinsona
removed
the
status: waiting-for-internal-feedback
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Sep 5, 2024
The subscription name config prop was not being set on the Pulsar listener container properties. This commit adds the subscription name to the Pulsar property mappers. See gh-42067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subscription name config prop was not being set on the Pulsar listener container properties. This commit adds the subscription name to the Pulsar property mappers.
Resolves #42053