Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate build to Spring Develocity Conventions extension #1954

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

erichaagdev
Copy link
Contributor

This PR migrates the build to use Spring's Develocity Conventions Maven extension.

https://github.com/spring-io/develocity-conventions

With this, explicit configuration of the Develocity Maven extension is no longer required, as all configuration is encapsulated within the Spring extension.

Additionally, build cache authentication now uses the Develocity access key, so separate build cache credentials are no longer required. The DEVELOCITY_ACCESS_KEY environment variable is enough for both build scan publishing and remote build cache access.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 31, 2024
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 1, 2024
@mp911de mp911de added this to the 5.2.9 (2023.1.9) milestone Aug 1, 2024
@mp911de mp911de merged commit e9c600a into spring-projects:main Aug 1, 2024
3 checks passed
mp911de pushed a commit that referenced this pull request Aug 1, 2024
* Migrate build to Spring Develocity Conventions extension.

* Adopt Develocity environment variables.

Closes #1954
mp911de pushed a commit that referenced this pull request Aug 1, 2024
* Migrate build to Spring Develocity Conventions extension.

* Adopt Develocity environment variables.

Closes #1954
@mp911de
Copy link
Member

mp911de commented Aug 1, 2024

Thank you for your contribution. That's merged and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants