Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Propagation.NEVER for disabling test-managed transactions #25909

Closed
3 tasks done
sbrannen opened this issue Oct 13, 2020 · 1 comment
Closed
3 tasks done

Support Propagation.NEVER for disabling test-managed transactions #25909

sbrannen opened this issue Oct 13, 2020 · 1 comment
Assignees
@sbrannen
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
5.3 GA

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 13, 2020 •
edited
Loading

Status Quo

Propagation.NOT_SUPPORTED can be used to disable test-managed transactions via the @Transactional annotation as documented in the Javadoc and reference manual, but Propagation.NEVER does not have the same effect even though users might assume it would (see spring-projects/spring-boot#23630 (comment)).

Deliverables

  • Support Propagation.NEVER for disabling test-managed transactions
  • Document in the Javadoc for TransactionalTestExecutionListener
  • Document in the reference manual
@sbrannen sbrannen self-assigned this Oct 13, 2020
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Oct 13, 2020
@sbrannen sbrannen modified the milestones: 5.3 RC2, 5.3 GA Oct 13, 2020
@sbrannen sbrannen mentioned this issue Oct 13, 2020
Closed
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Oct 13, 2020
@sbrannen
Support Propagation.NEVER for disabling test-managed transactions
47b25eb 
Prior to this commit only Propagation.NOT_SUPPORTED was supported for
disabling test-managed transactions via the `propagation` attribute of
`@Transactional`.

This commit allows users to specify Propagation.NOT_SUPPORTED or
Propagation.NEVER to disable test-managed transactions.

Closes spring-projectsgh-25909
@sbrannen
Copy link
Member Author

Pushed sbrannen@47b25eb to a feature branch awaiting the release of 5.3 RC2.

@sync-by-unito sync-by-unito bot mentioned this issue Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
5.3 GA
Development

No branches or pull requests
1 participant
@sbrannen