Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Javadoc in AcceptHeaderLocaleResolver #26793

Closed
m1stake opened this issue Apr 13, 2021 · 1 comment
Closed

Fix Javadoc in AcceptHeaderLocaleResolver #26793

m1stake opened this issue Apr 13, 2021 · 1 comment
Assignees
@sbrannen
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Milestone
5.3.6

Comments

@m1stake
Copy link

m1stake commented Apr 13, 2021

Affects: spring-webmvc 5.1.6.RELEASE

org.springframework.web.servlet.i18n.AcceptHeaderLocaleResolver.setDefaultLocale, line 74

// ...
// By default this is not set in which case when there is "Accept-Language" header 
// ...
public void setDefaultLocale(@Nullable Locale defaultLocale) { ... }

I think it means "when there is no 'Accept-Language' header".
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 13, 2021
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 13, 2021
@sbrannen sbrannen changed the title A comment error in org.springframework.web.servlet.i18n.AcceptHeaderLocaleResolver Fix Javadoc in AcceptHeaderLocaleResolver Apr 13, 2021
@sbrannen sbrannen self-assigned this Apr 13, 2021
@sbrannen sbrannen added this to the 5.3.6 milestone Apr 13, 2021
@sbrannen
Copy link
Member

This has been fixed in master.

Thanks

lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Fix Javadoc in AcceptHeaderLocaleResolver
1be96a4 
Closes spring-projectsgh-26793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Milestone
5.3.6
Development

No branches or pull requests
3 participants
@sbrannen @m1stake @spring-projects-issues