Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy "application/graphql" is not supported if charset is set #1038

Closed
github-actions bot opened this issue Jul 26, 2024 · 1 comment
Closed

Legacy "application/graphql" is not supported if charset is set #1038

github-actions bot opened this issue Jul 26, 2024 · 1 comment
Assignees
@bclozel
Labels
in: web Issues related to web handling type: backport type: bug A general bug
Milestone
1.2.9

Comments

@github-actions
Copy link
Contributor

Backport of gh-1036
@github-actions github-actions bot added in: web Issues related to web handling type: backport type: bug A general bug labels Jul 26, 2024
@github-actions github-actions bot added this to the 1.2.9 milestone Jul 26, 2024
bclozel added a commit that referenced this issue Jul 26, 2024
@bclozel
Support application/graphql with charset information
5ffe512 
Prior to this commit, gh-948 added a fallback support for the
"application/graphql" content-type sent by clients. This media type is
not widely used and advised against by the spec group.

This fallback checked for an exact match of the content type, not taking
into account potential media type parameters such as charset.

This commit ensure that a `MediaType#include` comparison is used to
trigger the fallback.

Fixes gh-1038
@bclozel bclozel self-assigned this Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

Fixed via 5ffe512

@martinvisser martinvisser mentioned this issue Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues related to web handling type: backport type: bug A general bug
Projects
None yet
Milestone
1.2.9
Development

No branches or pull requests
1 participant
@bclozel