Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultExecutionRequestObservationConvention does not produce INTERNAL_ERROR outcomes #1065

Closed
github-actions bot opened this issue Oct 9, 2024 · 1 comment
Closed

DefaultExecutionRequestObservationConvention does not produce INTERNAL_ERROR outcomes #1065

github-actions bot opened this issue Oct 9, 2024 · 1 comment
Assignees
@bclozel
Labels
in: core Issues related to config and core support type: backport type: bug A general bug
Milestone
1.2.9

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Backport of gh-1058
@github-actions github-actions bot added in: core Issues related to config and core support type: backport type: bug A general bug labels Oct 9, 2024
@github-actions github-actions bot added this to the 1.2.9 milestone Oct 9, 2024
bclozel added a commit that referenced this issue Oct 9, 2024
@bclozel
Produce INTERNAL_ERROR observation outcome
b8b93a0 
Prior to this commit, the `DefaultExecutionRequestObservationConvention`
would only produce "INTERNAL_ERROR" outcomes if the response is null or
if an unresolved exception remains.

The `ExceptionResolversExceptionHandler` will catch all unresolved
exceptions and add them to the errors map with the
`ErorType.INTERNAL_ERROR` error type. This means that the
"INTERNAL_ERROR" outcome is never used.

This commit ensures that this outcome is also used if at least one
resolved error is of `ErorType.INTERNAL_ERROR`.

Fixes gh-1065
@bclozel bclozel self-assigned this Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Oct 9, 2024

Fixed via b8b93a0

@github-actions github-actions bot closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: core Issues related to config and core support type: backport type: bug A general bug
Projects
None yet
Milestone
1.2.9
Development

No branches or pull requests
1 participant
@bclozel