Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise BindException from GraphQlArgumentBinder with binding errors #280

Closed
rstoyanchev opened this issue Feb 3, 2022 · 0 comments
Closed

Raise BindException from GraphQlArgumentBinder with binding errors #280

rstoyanchev opened this issue Feb 3, 2022 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
1.0.0-M6

Comments

@rstoyanchev
Copy link
Contributor

Currently it may raise a TypeMismatchException if a constructor argument cannot be converted to the expected type, and others like IllegalStateException, but if DataBinder is used then conversion errors are not checked in the BindingResult. We should ensure a BindException is raised consistently indicating which fields could not be bound.
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Feb 3, 2022
@rstoyanchev rstoyanchev added this to the 1.0.0-M6 milestone Feb 3, 2022
@rstoyanchev rstoyanchev mentioned this issue Feb 3, 2022
Closed
rstoyanchev added a commit that referenced this issue Mar 22, 2022
@rstoyanchev
Polishing
7e43223 
See gh-280
rstoyanchev added a commit that referenced this issue Mar 22, 2022
@rstoyanchev
Minor refactoring
0e2c5be 
Avoid creating a map for a nested list.

See gh-280
@rstoyanchev rstoyanchev changed the title Review exceptions raised from GraphQlArgumentInitializer Raise BindException from GraphQlArgumentInitializer with binding errors Mar 22, 2022
@rstoyanchev rstoyanchev changed the title Raise BindException from GraphQlArgumentInitializer with binding errors Raise BindException from GraphQlArgumentBinder with binding errors Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0.0-M6
Development

No branches or pull requests
1 participant
@rstoyanchev