Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start and stop methods to RSocketGraphQlClient #378

Closed
rstoyanchev opened this issue May 5, 2022 · 0 comments
Closed

Add start and stop methods to RSocketGraphQlClient #378

rstoyanchev opened this issue May 5, 2022 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented May 5, 2022

This came up as part of documentation changes for #368. Currently, the only way to stop the session is to call dispose on the underlying RSocketRequester but RSocketGraphQlClient can built without providing a requester instance and by only specifying the target URI. There should be a first-class stop() method to use regardless of how the client is created. Likewise, there should be a similar start() method for the same reason.

Note that currently stop cannot be properly implemented to return Mono<Void> but that should be possible after rsocket/rsocket-java#1048.

@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label May 5, 2022
@rstoyanchev rstoyanchev added this to the 1.0.0 milestone May 5, 2022
@rstoyanchev rstoyanchev self-assigned this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant