-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide advice on number of instances and connections for WebSocketGraphQlClient and RSocketGraphQlClient #368
Comments
We have plans to replace the samples, see #208. You could leave a comment there, but generally, the client and tester APIs are pretty well aligned. They should feel the same to create and execute a request. There is also the reference docs. |
Documentation does not tells how to execute the request its only constructing the object for client. |
Regarding lifecycle questions, most likely you'll want a singleton assuming you want to have one, shared (multiplexed) connection at a time. There are methods for start and stop, and the Javadoc should help to fill in a few of these blanks, but overall, we can use this as an opportunity to improve the reference documentation. As for executing requests, there is a section focusing on requests, which is independent of how the client was created. Could you take a look and see if anything is missing from your perspective? |
Also minor fix for WebSocket client subsections that appeared incorrectly nested under RSocket. See gh-368
Please add sample application for WebSocketGraphQlClient which uses ReactorNettyWebSocketClient
https://github.com/spring-projects/spring-graphql/tree/main/samples/webflux-websocket this uses GraphqlTester API for client which does not demonstrate actual usage of WebSocketGraphQlClient with ReactorNettyWebSocketClient
The text was updated successfully, but these errors were encountered: