Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with the Micrometer Context Propagation library #459

Closed
rstoyanchev opened this issue Aug 4, 2022 · 0 comments
Closed

Integrate with the Micrometer Context Propagation library #459

rstoyanchev opened this issue Aug 4, 2022 · 0 comments
Assignees
@rstoyanchev
Labels
type: enhancement A general enhancement
Milestone
1.1.0-M1

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Aug 4, 2022 •
edited
Loading

The context-propagation library under micrometer-metrics is partly a result of the experience in Spring for GraphQL, but also more generally a result of the experience with context propagation in a wide range of applications with reactive and asynchronous logic. For 1.1, we can use this library to replace the custom solution in Spring for GraphQL.
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Aug 4, 2022
@rstoyanchev rstoyanchev added this to the 1.1.0-M1 milestone Aug 4, 2022
@rstoyanchev rstoyanchev self-assigned this Aug 4, 2022
rstoyanchev added a commit that referenced this issue Aug 31, 2022
@rstoyanchev
Switch to io.micrometer:context-propagation library
f680892 
See gh-459
rstoyanchev added a commit that referenced this issue Aug 31, 2022
@rstoyanchev
Remove built-in ThreadLocalAccessor
f5e7103 
The ThreadLocalAccessor in 1.0 was intended as a temporary solution
that is now replaced by a similar contract in the
`io.micrometer:context-propagation` library.

Unfortunately, there is no way to adapt one to the other, but
it is trivial to implement the new contract and register it either with
`ContextRegistry#getInstance` on startup or through the
`ServiceLoader` mechanism.

See gh-459
rstoyanchev added a commit that referenced this issue Sep 1, 2022
@rstoyanchev
Temporarily revert to Micrometer context-propagation M4
4868ab4 
See gh-459
@rstoyanchev rstoyanchev changed the title Integrate with context-propagation library under micrometer-metrics Integrate with the Micrometer Context Propagation library Sep 2, 2022
@bclozel bclozel mentioned this issue Sep 8, 2022
Closed
@rstoyanchev rstoyanchev mentioned this issue Sep 15, 2022
Open
@rstoyanchev rstoyanchev mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.1.0-M1
Development

No branches or pull requests
1 participant
@rstoyanchev