Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Propagation to DataFetcher's with Spring MVC #53

Closed
rstoyanchev opened this issue May 18, 2021 · 0 comments
Closed

Context Propagation to DataFetcher's with Spring MVC #53

rstoyanchev opened this issue May 18, 2021 · 0 comments
Assignees
Labels
in: core Issues related to config and core support in: web Issues related to web handling type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented May 18, 2021

For Spring Security support on Spring MVC, we'll need context propagation.

Initially the request is on a Servlet container thread with ThreadLocal context, then it passes through the Reactor web interception chain before getting to GraphQL where DataFetchers are invoked and those would be expected to be imperative but also potentially reactive.

We'll need to assist with context propagation for this to work seamlessly. It will probably involve some mechanism that enables Spring Security or others to help decide which ThreadLocal context to propagate.

@rstoyanchev rstoyanchev added type: enhancement A general enhancement in: core Issues related to config and core support in: web Issues related to web handling labels May 18, 2021
@rstoyanchev rstoyanchev added this to the 0.1.0 milestone May 18, 2021
@rstoyanchev rstoyanchev self-assigned this May 18, 2021
rstoyanchev added a commit that referenced this issue May 28, 2021
To allow adding more options when creating a WebGraphQlHandler.

See gh-53
rstoyanchev added a commit that referenced this issue Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues related to config and core support in: web Issues related to web handling type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant