-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide hook with access to schema mappings inspection report #672
Comments
Something like this, which can then be applied from a GraphQlSource.schemaResourceBuilder()
.schemaResources()
.inspectSchemaMappings(report -> {
// ...
})
.build(); If this is configured, we won't log the report. It'll be all up to the callback. |
Yes. I think that is a good approach with the customizer + default with the option to use our own implementation. |
I think we need to significantly refactor the |
@danielshiplett I've added a |
@rstoyanchev This seems to work as expected. I have created a demonstration that invokes Spring's Failure Analysis feature to stop the application and provide feedback. Here is the configuration class that does that. Here is some example output where a single mapping and a single registration were in error:
|
Thanks for confirming and for the example! I noticed a few bullet items under the Status section in the README. Is there anything there that remains not done? |
We can expose a hook that provides access to the
Report
and allows applications to take some actions. The default action would be to log it, which is what we do currently.Requested in #386 (comment).
The text was updated successfully, but these errors were encountered: