False positives in Schema inspection when using Lists in CompletableFuture

[JamesPeters98]

I just got around to testing the new schema inspection #386 when upgrading to Spring Boot 3.1 RC1. I seem to be getting false positives for unmapped fields that have a java field.

I think it happens when the controller method is a CompletableFuture of a List of the object:

@Controller
public class ExampleQueryController {
  @QueryMapping
  public CompletableFuture<List<ExampleObject>> exampleObject(DataFetchingEnvironment env) {
    return CompletableFuture.completedFuture(List.of(new ExampleObject(1, "name")));
  }

}

GraphQL schema:

type ExampleObject {
  name: String,
  id: Int
}

type Query {
  exampleObject: [ExampleObject]
}

Object class:

public class ExampleObject {

  public String name;
  public int id;

  public ExampleObject(int id, String name) {
    this.id = id;
    this.name = name;
  }

  public Integer getId() {
    return id;
  }

  public String getName() {
    return name;
  }

}

This results in the schema inspection giving a false positive that name and id aren't mapped for ExampleObject.

[rstoyanchev]

@JamesPeters98, this should now be fixed. Please, take another look and let us know if you have further feedback. Also, note that in the latest version of this, the inspection does not run automatically. You need to enable it in GraphQlSource.Builder. The reference docs have been updated.

[JamesPeters98]

@rstoyanchev Thanks, can confirm this is working for me now 👍

[rstoyanchev]

Good to hear, and thanks for giving it a try!