Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Spring Data 2023.0.0 #679

Closed
1 task done
rstoyanchev opened this issue Apr 27, 2023 · 0 comments
Closed
1 task done

Upgrade to Spring Data 2023.0.0 #679

rstoyanchev opened this issue Apr 27, 2023 · 0 comments
Assignees
@bclozel
Labels
type: dependency-upgrade A dependency upgrade
Milestone
1.2.0

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Apr 27, 2023 •
edited by bclozel
Loading

We're expecting some minor breaking changes to the new ScrollPosition API, and will switch to snapshots soon for that.
@rstoyanchev rstoyanchev added this to the 1.2.0 milestone Apr 27, 2023
@rstoyanchev rstoyanchev added the type: dependency-upgrade A dependency upgrade label Apr 27, 2023
odrotbohm added a commit to odrotbohm/spring-graphql that referenced this issue Apr 27, 2023
@odrotbohm
Adapt to API changes in Spring Data's ScrollPosition APIs.
60984a0 
We now use the factory methods introduced on ScrollPosition to create new instances of both Keyset- as well as OffsetScrollPosition. Also simplified a few places in which the API now provides a more convenient way to advance offsets.

Related ticket: spring-projects#679.
@odrotbohm odrotbohm mentioned this issue Apr 27, 2023
Closed
rstoyanchev pushed a commit that referenced this issue Apr 28, 2023
@odrotbohm @rstoyanchev
Adapt to API changes in Spring Data's ScrollPosition APIs.
cd3cf9d 
We now use the factory methods introduced on ScrollPosition to create new instances of both Keyset- as well as OffsetScrollPosition. Also simplified a few places in which the API now provides a more convenient way to advance offsets.

Related ticket: #679.
@bclozel bclozel self-assigned this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@bclozel @rstoyanchev