Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema mapping should inspect fields that have a matching class property #934

Closed
rstoyanchev opened this issue Mar 26, 2024 · 0 comments
Closed
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Mar 26, 2024

Currently schema mapping does not inspect fields that have a matching class property, and generally there is nothing further to do if the field is a scalar or enum, which is the most likely case. However, if the field is a type that contains other fields, then we have to go further. It is an unlikely scenario that implies eager fetching, but from the perspective of schema inspection we need to go as far as we can and depending on what we find.

@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Mar 26, 2024
@rstoyanchev rstoyanchev added this to the 1.3.0-RC1 milestone Mar 26, 2024
@rstoyanchev rstoyanchev self-assigned this Mar 26, 2024
rstoyanchev added a commit that referenced this issue Mar 26, 2024
Rather than passing a DataFetcher into checkField, determine the return type
externally and pass it in. That makes the method more generally useful, and
independent of how the associated type is determined, e.g. whether from a
DataFetcher return type or a corresponding Java property.

See gh-934
rstoyanchev added a commit that referenced this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant