Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare HTTP handlers for Incremental Delivery support #959

Closed
rstoyanchev opened this issue Apr 25, 2024 · 0 comments
Closed

Prepare HTTP handlers for Incremental Delivery support #959

rstoyanchev opened this issue Apr 25, 2024 · 0 comments
Assignees
@rstoyanchev
Labels
type: enhancement A general enhancement
Milestone
1.3.0

Comments

@rstoyanchev
Copy link
Contributor

In #309 we introduced a base class for HTTP handlers with re-usable protected methods and common fields. We can take it a step further and implement request handling, leaving only response handling to sub-classes. This will help re-use across HTTP and SSE handling, and make it easier to create a handler for the incremental delivery (experimental) support in GraphQL Java 22.
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Apr 25, 2024
@rstoyanchev rstoyanchev added this to the 1.3.0 milestone Apr 25, 2024
@rstoyanchev rstoyanchev self-assigned this Apr 25, 2024
rstoyanchev added a commit that referenced this issue Apr 25, 2024
@rstoyanchev
Refactoring in server handlers
6376ec9 
In preparation to move handleRequest method up.

See gh-959
rstoyanchev added a commit that referenced this issue Apr 25, 2024
@rstoyanchev
Align future handling with AsyncServerResponse
f61dfc5 
See gh-959
@rstoyanchev rstoyanchev changed the title Make it easier to extend HTTP handlers Prepare HTTP handlers for Incremental Delivery support Apr 26, 2024
rstoyanchev added a commit that referenced this issue Apr 26, 2024
@rstoyanchev
Add protected encode method to WebFlux AbstractGraphQlHttpHandler
1ea64dc 
This helps to encode directly when needed, e.g. for multipart
stream with incremental delivery.

See gh-959
@rstoyanchev rstoyanchev mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@rstoyanchev