Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actual elements to message of containsAll #507

Closed
wants to merge 1 commit into from

Conversation

koenpunt
Copy link
Contributor

To make the message more useful I now often replace the matcher with a variant of isEqualTo because that shows me a message with what the actual items are.

With the updated message that's no longer necessary.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 17, 2022
@rstoyanchev rstoyanchev self-assigned this Oct 17, 2022
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 17, 2022
@rstoyanchev rstoyanchev modified the milestones: 1.1.0-RC1, 1.0.3 Oct 17, 2022
rstoyanchev pushed a commit that referenced this pull request Oct 17, 2022
@koenpunt koenpunt deleted the contains-all-message branch October 17, 2022 17:19
koenpunt added a commit to koenpunt/spring-graphql that referenced this pull request Feb 2, 2023
koenpunt pushed a commit to koenpunt/spring-graphql that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants