-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Antora documentation site #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the antora-playbook.yml
meant to be in the docs-build branch, i.e. shared across branches? In spring-framework we have the cached-antora-playbook.yml
which is listed .gitignore. I don't see anything added to .gitignore here.
@rstoyanchev I'm moving away from the approach of the shared docs-build antora-playbook.yml because it is an non-versioned resource that will be in a tag and potentially break later. I think it is better to just include the playbook in the branches going forward. If you prefer we can use the shared antora-playbook.yml strategy, but I think this is a better approach. PS: I haven't started any effort on changing existing builds to use this approach, but I'm doing it going forward. |
Okay thanks for clarifying. |
No description provided.