Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for injection Annotations #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gayanper
Copy link
Contributor

@gayanper gayanper commented Feb 9, 2019

Change-Id: I6e35104c9d254a818aa22c1ee679d43c2456d4a2
Signed-off-by: gayanper [email protected]

Change-Id: I6e35104c9d254a818aa22c1ee679d43c2456d4a2
Signed-off-by: gayanper <[email protected]>
@gayanper
Copy link
Contributor Author

gayanper commented Feb 9, 2019

PR which adds support for mostly used injection annotations.

@martinlippert
Copy link
Member

Great that you found the time to work on this, much appreciated. Before we can merge the PR, I would need to have a bunch of automated tests for this new symbol provider, as we have for the other symbol providers. That usually involves creating a test project with some sample sources included and writing the unit tests for that, maybe similar to the SpringIndexerBeansTest (but there are others, too).

@gayanper
Copy link
Contributor Author

Sure i will work on it. What do you think about the @= prefix?

@martinlippert
Copy link
Member

The prefix in general sounds fine to me, but I always need to play around with early prototypes and see the things in action to really be able to make up my mind about them. But changing that prefix in the future (if necessary) is not a big deal, maybe you should extract that into a constant to make it even easier.

@abha68738
Copy link

Nice Work Dude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants