-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from 'redirect:' prefix to ResponseEntity for redirecting UI index #1104
switch from 'redirect:' prefix to ResponseEntity for redirecting UI index #1104
Conversation
I would like to add some tests for this, but I didn't manage to succeed. The existing tests, that check the Location header e.g. |
Thank for your contribution. The tricky issue you had reported may need better integration tests. As far as the existing tests are passing, i will accept PR. |
I was wondering if HTTP 302 is the proper response code as springdoc-openapi-webflux-ui returns 307 for the same use case. I found this on MDN
So it wouldn't really change anything in this case since we only allow GET requests, but maybe we should make the return code consistent. What do you think? |
I had the same thoughts. I think http 302 is much better. |
I will propose a PR later tonight |
fixes #1100