(fix): Google pubsub protocol schema setting - cloudsteam #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for springwolf-ui canceled.
|
timonback
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Great that you start working on supporting GooglePubSub bindings.
I left some comments regarding structure. In case you need some assistance with the bindings module, lets hop into the Discord chat together with @ctasada to coordinate (we can also move the files at the end of the PR).
(I usually do not review PR as long as they are in the draft state. Thanks for the ping in Discord.)
...gwolf/plugins/cloudstream/asyncapi/scanners/channels/CloudStreamFunctionChannelsScanner.java
Outdated
Show resolved
Hide resolved
...main/java/io/github/springwolf/plugins/cloudstream/annotation/GooglePubSubSchemaSetting.java
Outdated
Show resolved
Hide resolved
...main/java/io/github/springwolf/plugins/cloudstream/annotation/GooglePubSubSchemaSetting.java
Outdated
Show resolved
Hide resolved
...ub/springwolf/plugins/cloudstream/asyncapi/scanners/common/FunctionalChannelBeanBuilder.java
Outdated
Show resolved
Hide resolved
...loudstream/asyncapi/scanners/channels/CloudStreamFunctionChannelsScannerIntegrationTest.java
Outdated
Show resolved
Hide resolved
timonback
approved these changes
Mar 22, 2024
|
Thank you @SheheryarAamir for the contribution. It will be part of the next release 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using googlepubsub as protocol generated asynapi docs does not add schemaSetting under bindings->googlepubsub, which is required for passing asynapi validation.
Detailed are mentioned in below reported issue
Issue #651