-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pip installer. #206
base: master
Are you sure you want to change the base?
Add pip installer. #206
Conversation
Variable needs to be named "pip" or "package" everywhere. Should be consistent between check and installer. |
Reason this can't use auto api? |
I followed Some installers use
I followed |
Does method="def #{method_name}(*names, &block)
install #{class_name}.new(self, *names, &block)
end" It seems that a lot of package installers do not support |
Some installers are in different states than others, they probably all should properly support sudo.
Do you have an idea of how? The problem is when you use *array that then taking other arguments becomes problematic. This installer doesn't currently use options in any case so it seems like auto-api could be used as-is. |
|
||
verify_api do | ||
def has_pip(package) | ||
@commands << "pip show #{package} | fgrep Name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer grep -F
and lets match 'Name:' with the colon to be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New commits pushed uses grep -F
instead of fgrep
,
with comments on matching pattern.
Also replace `fgrep` and `grep -F`.
No description provided.