Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spritesheets are re-published after merely selecting them #736

Closed
LearnCocos2D opened this issue Jul 30, 2014 · 4 comments · Fixed by #790
Closed

Spritesheets are re-published after merely selecting them #736

LearnCocos2D opened this issue Jul 30, 2014 · 4 comments · Fixed by #790
Assignees
Labels

Comments

@LearnCocos2D
Copy link
Contributor

Every time I simply click on a Spritesheet folder, SB will re-publish that particular spritesheet. Apparently merely the act of selecting the spritesheet folder flags the spritesheet as "dirty".

Note: selecting one of the images contained in the spritesheet does not cause a re-publish.

@NickyWeber
Copy link
Contributor

I cannot reproduce this on develop (2201c04) nor on 1.1 (App Store version).

Did you select Release for publishing?

My steps:

  • I created a clean project
  • Publish mode is Develop
  • Created a folder
  • drag and dropped some good bunch of large images
  • Turned that folder into a smart sprite sheet
  • Project Settings: All resolutions are checked so publishing takes a noticeably long time
  • Publish: takes some time
  • Opened that sprite sheet folder selected an image inisde
  • Publish: very fast
  • Selected the Smar Sprite Sheet again
  • Publish: very fast

@LearnCocos2D
Copy link
Contributor Author

Try it with the LearnSpriteBuilder project here:
https://github.com/learnCocos2D/sbcc

I have develop mode selected in SB but I'm building the release configuration in Xcode. I can definitely reproduce it just by clicking on the spritesheets in the SpriteSheets folder.

Edit: also happens when I build debug config in Xcode, so that's not it.

@LearnCocos2D
Copy link
Contributor Author

  • Opened that sprite sheet folder selected an image inisde

Like I said, you have to select the spritesheet (folder) itself. Selecting images contained in the folder does not cause the issue. P

If you have just one spritesheet, be sure to select a different folder, then publish, then select the spritesheet folder again, and publish again to see if just clicking on the spritesheet causes a re-publish.

Though for me the following does provoke a re-publish so it may not be necessary to select something outside the spritesheet:

  • select spritesheet folder
  • publish (takes a while)
  • select images contained in spritesheet
  • publish (fast)
  • select spritesheet folder again
  • publish (takes a while)

@LearnCocos2D
Copy link
Contributor Author

Also noticed that the re-publish occurs on the Tileless Editor View tab. Merely checking and unchecking the sprite sheet in the Filter Folders section at the bottom of the view causes a re-publish. This occurs for both checking and unchecking the sprite sheet.

NickyWeber added a commit to NickyWeber/SpriteBuilder that referenced this issue Aug 20, 2014
…d it as dirty.

This lead to redundant publishing passes.
vlidholt added a commit that referenced this issue Aug 21, 2014
…e_marks_them_as_dirty

Bugfix/#736 selecting resource marks them as dirty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants