Add FileSystemResolver(Path) constructor #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spullara#223 Make FileSystemResolver(Path) use NIO APIs underneath and support non-default file systems, but otherwise make its observable behavior identical to FileSystemResolver(path.toFile()), including corner cases. Add tests demonstrating current behavior of ClasspathResolver and FileSystemResolver, even when that behavior is questionable.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
Reopening PR #224, which was opened against the old
masterbranch instead of the newmainbranch.Make FileSystemResolver(Path) use NIO APIs underneath and support
non-default file systems, but otherwise make its observable behavior
identical to FileSystemResolver(path.toFile()), including corner cases.
Add tests demonstrating current behavior of ClasspathResolver and
FileSystemResolver, even when that behavior is questionable.