-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular attempt for bindings #154
Comments
@dpizetta it sounds like a good idea :-) @ccordoba12 ? Just for context, is there any particular issues on your side that would directly benefit from this? Like an example of what was the problem? |
I would add that we need to add an else check so that if the last item in the list is not found, it should say something regarding that, instead of saying that it failed to use whatever binding check came last. Pyside at the moment, which is misleading |
@dpizetta, I like it! But things should not be circular. Instead we should always prefer the bindings for the same Qt major version, then the other ones. And the PyQt bindings should be preferred over the PySide ones because they are more stable. So, according to what you post above:
|
Hi @goanpeca , @ccordoba12 thank you. I agree with your comments. Implementing this proposal also include the additional feature from @goanpeca. I'll post PR soon. |
Thanks @dpizetta :-) ! |
@goanpeca > Just for context, is there any particular issues on your side that would directly benefit from this? Like an example of what was the problem? |
I think what he meant is that if all four bindings are tried and none is found, then If that happens right now, then we're printing a message about the lack of PySide (the last binding we look for its presence), which confuses users because they think they need to install PySide (to fulfill Spyder requirements, for example). |
Any date for this milestone? |
@ccordoba12 do we have an estimated date, or is this the next major one? |
Sure will do :-) |
Hi, I'd like to implement a change for setup the binding in a circular form. Here is an example.
If the preference list is [pyqt5, pyside2, pyqt, pyside]:
I think this would improve the auto setup and even the message that the "qtpy.PythonQtError: No Qt bindings could be found", because if you choose the last one, all the previous are not tested, so it is not "not found" actually.
Let me know what do you think about it, tks
The text was updated successfully, but these errors were encountered: