Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove unmaintained pytest-ordering package #14935

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

bnavigator
Copy link
Contributor

Description of Changes

pytest-ordering is not maintained and broken:
ftobia/pytest-ordering#73

This PR removes it. Tests should be written in a way that they are independent of each other.

Alternatively, if the order of tests is really needed, you may consider using forked and maintained https://github.com/pytest-dev/pytest-order with more concise mark names.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: bnavigator

@ccordoba12
Copy link
Member

Alternatively, if the order of tests is really needed, you may consider using forked and maintained https://github.com/pytest-dev/pytest-order with more concise mark names.

You're welcome to help us migrate our tests to pytest-order. Otherwise, you'll have to wait until we have time to do this because things are working fine for us with Pytest 5 (our current requirement).

@bnavigator
Copy link
Contributor Author

I reverted the removal and replaced with marks from pytest-order instead.

Conda does not have pytest-order yet :(

@ccordoba12 ccordoba12 changed the title remove unmaintained pytest ordering PR: Remove unmaintained pytest-ordering package Mar 29, 2021
@ccordoba12
Copy link
Member

I reverted the removal and replaced with marks from pytest-order instead.

Thanks for your help @bnavigator!

Conda does not have pytest-order yet :(

I added the requirement to our own Anaconda channel to fix that in the meantime.

@ccordoba12 ccordoba12 added this to the v5.0.1 milestone Mar 29, 2021
@ccordoba12 ccordoba12 modified the milestones: v5.0.1, v5.0.2 Apr 5, 2021
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Apr 6, 2021
https://build.opensuse.org/request/show/881754
by user bnavigator + RBrownSUSE
- Remove removal of early QtWebEngine import before tests. It
   triggered a fallback to testing with qtwebkit which is being
   removed from Tumbleweed
- Switch to xvfb-run instead of pytest-xvfb to avoid
  gh#The-Compiler/pytest-xvfb#11
- Replace pytest-ordering marks with pytest-order
  gh#spyder-ide/spyder#14935
- Update to version 4.2.5
  * Fix restoring window properties at startup.
  * Fix a segfault when restarting kernels.
  * Fix a segfault when processing linting results.
- Update to version 4.2.4
  * Fix an important error when restarting kernels.
  * Add compatibility with the future Spyder
ccordoba12
ccordoba12 previously approved these changes Apr 25, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnavigator!

@ccordoba12 ccordoba12 changed the base branch from master to 5.x April 25, 2021 19:45
@ccordoba12 ccordoba12 dismissed their stale review April 25, 2021 19:45

The base branch was changed.

@ccordoba12 ccordoba12 merged commit 98781c9 into spyder-ide:5.x Apr 25, 2021
ccordoba12 added a commit that referenced this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants