Skip to content

Commit

Permalink
changelog / docstring edits
Browse files Browse the repository at this point in the history
Change-Id: I89be3f965d3556694f497a47a6b13247ce2a1d94
  • Loading branch information
zzzeek committed May 7, 2021
1 parent 4b0797f commit 33180bf
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 4 additions & 2 deletions docs/build/unreleased/839.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,7 @@
:tags: bug, versioning, regression
:tickets: 839

Fixed regression in new versioning traversal where "alembic downgrade head"
(or equivalent) fails instead of iterating no revisions.
Fixed additional regression nearly the same as that of :ticket:`838` just
released in 1.6.1 but within a slightly different codepath, where "alembic
downgrade head" (or equivalent) would fail instead of iterating no
revisions.
6 changes: 6 additions & 0 deletions tests/test_version_traversal.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,17 @@ def test_downgrade_base_no_version(self):
self._assert_downgrade("base", [], [], set())

def test_downgrade_to_existing(self):
"""test for #838; downgrade to a revision that's already in
current heads, but is not itself a head."""

self._assert_downgrade(
self.a.revision, [self.a.revision], [], {self.a.revision}
)

def test_downgrade_to_existing_head(self):
"""test for #839; downgrade to a revision that's already in current
heads, which *is* itself a head."""

self._assert_downgrade(
self.e.revision, [self.e.revision], [], {self.e.revision}
)
Expand Down

0 comments on commit 33180bf

Please sign in to comment.