Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use column.copy() for column operations due to SQLAlchemy "column is already attached" issue #753

Closed
zzzeek opened this issue Nov 5, 2020 · 1 comment
Closed

use column.copy() for column operations due to SQLAlchemy "column is already attached" issue #753

zzzeek opened this issue Nov 5, 2020 · 1 comment
Labels
bug Something isn't working op directives

Comments

@zzzeek
Copy link
Member

zzzeek commented Nov 5, 2020

the change in sqlalchemy/sqlalchemy#5618 is now hitting me as I'm trying to write a recipe for someone. when we take columns into the operations we should just run _copy() on them so that we dont get the already attached to table issue.
@zzzeek zzzeek added requires triage New issue that requires categorization bug Something isn't working op directives and removed requires triage New issue that requires categorization labels Nov 5, 2020
@sqla-tester
Copy link
Collaborator

Mike Bayer has proposed a fix for this issue in the master branch:

Copy column that's already attached https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2345

@zzzeek zzzeek mentioned this issue Nov 5, 2020
Closed
fitzoh added a commit to fitzoh/alembic that referenced this issue Feb 6, 2021
@fitzoh
Update cookbook.rst references to sqlalchemy#753
a403097 
A fix for sqlalchemy#753 was merged in November 2020 and released in 1.5.0 in January 2021.
This updates the references to sqlalchemy#753 in cookbook.rst to note that a fix for sqlalchemy#753 has been released.
@fitzoh fitzoh mentioned this issue Feb 6, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working op directives
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zzzeek @sqla-tester