unique/index flag broken by acc82bf #848
Labels
Comments
zzzeek
added
requires triage
|
Mike Bayer has proposed a fix for this issue in the master branch: differentiate CreateTableOp from model vs. op.create_table() https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2839 |
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this issue
May 25, 2021
* Update requirements from branch 'master'
to 7577743d00aa50da768b2fa562290abbdee0acb7
- Block alembic 1.6.3
As described in [1], since #844 was introduced, when a table is
created, all columns "index" and "unique" flags are unset.
In 1.6.4 [2], "CreateTableOp" sets the flag
"_constraints_included" to False by default. That will honor
the "index" and "unique" flags set in each column definition.
Related-Bug: #1929518
[1]sqlalchemy/alembic#848
[2]https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2839
Change-Id: I90380b027cade633088099ae766ff5c116014cea
openstack-mirroring
pushed a commit
to openstack/requirements
that referenced
this issue
May 25, 2021
As described in [1], since #844 was introduced, when a table is created, all columns "index" and "unique" flags are unset. In 1.6.4 [2], "CreateTableOp" sets the flag "_constraints_included" to False by default. That will honor the "index" and "unique" flags set in each column definition. Related-Bug: #1929518 [1]sqlalchemy/alembic#848 [2]https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2839 Change-Id: I90380b027cade633088099ae766ff5c116014cea
mgasner
added a commit
to dagster-io/dagster
that referenced
this issue
May 25, 2021
Summary: Alembic 1.6.3 broke us, and this has been fixed in 1.6.4. See sqlalchemy/alembic#844 and sqlalchemy/alembic#848. Test Plan: Unit Reviewers: dgibson, alangenfeld, prha Reviewed By: dgibson Differential Revision: https://dagster.phacility.com/D8093
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this issue
Jun 3, 2021
* Update neutron from branch 'master'
to 7e98d189270c408b4a5f5b69e9e479a458407b22
- Merge "Switch neutron-rally-task job to ML2/OVS and skip "test_models_sync""
- Switch neutron-rally-task job to ML2/OVS and skip "test_models_sync"
After switch of the default Neutron backend to the ML2/OVN
in the Devstack we had 2 rally jobs running actually with the
same Neutron backend.
This patch configures explicitly ML2/OVS as a backend in the
'neutron-rally-task' job so it is like it was before the change in
the Devstack repo.
In order to fix the CI, this patch also skips "test_models_sync" test
cases. Once [1] is fixed and released, we'll be able to create SQL
tables specifying the "_constraints_included" flag. When creating a
table, this flag should be set to "False" in order to be able to set
the "index" and "unique" parameters for each column in the table
definition, as we do now.
"test_update_router_admin_state" is excluded from
"neutron-ovn-tempest-slow" until LP#1890445 is fixed.
Set "test_restart_wsgi_on_sighup_multiple_workers" as unstable.
CI job "neutron-ovn-tempest-slow" has been set to non-voting until
LP#1930402 is fixed.
Related-Bug: #1929518
Related-Bug: #1890445
Related-Bug: #1930402
Related-Bug: #1930367
[1]sqlalchemy/alembic#848
Change-Id: I38ed7931169434fecbbefa3762f51a522ef3c509
openstack-mirroring
pushed a commit
to openstack/neutron
that referenced
this issue
Jun 3, 2021
After switch of the default Neutron backend to the ML2/OVN in the Devstack we had 2 rally jobs running actually with the same Neutron backend. This patch configures explicitly ML2/OVS as a backend in the 'neutron-rally-task' job so it is like it was before the change in the Devstack repo. In order to fix the CI, this patch also skips "test_models_sync" test cases. Once [1] is fixed and released, we'll be able to create SQL tables specifying the "_constraints_included" flag. When creating a table, this flag should be set to "False" in order to be able to set the "index" and "unique" parameters for each column in the table definition, as we do now. "test_update_router_admin_state" is excluded from "neutron-ovn-tempest-slow" until LP#1890445 is fixed. Set "test_restart_wsgi_on_sighup_multiple_workers" as unstable. CI job "neutron-ovn-tempest-slow" has been set to non-voting until LP#1930402 is fixed. Related-Bug: #1929518 Related-Bug: #1890445 Related-Bug: #1930402 Related-Bug: #1930367 [1]sqlalchemy/alembic#848 Change-Id: I38ed7931169434fecbbefa3762f51a522ef3c509
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this issue
May 20, 2024
As described in [1], since #844 was introduced, when a table is created, all columns "index" and "unique" flags are unset. In 1.6.4 [2], "CreateTableOp" sets the flag "_constraints_included" to False by default. That will honor the "index" and "unique" flags set in each column definition. Related-Bug: #1929518 [1]sqlalchemy/alembic#848 [2]https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2839 Change-Id: I90380b027cade633088099ae766ff5c116014cea
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this issue
May 20, 2024
As described in [1], since #844 was introduced, when a table is created, all columns "index" and "unique" flags are unset. If [2] is merged, the "CreateTableOp" will set the flag "_constraints_included" to False. That will honor the "index" and "unique" flags set in each column definition. Related-Bug: #1929518 [1]sqlalchemy/alembic#848 [2]https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2839 Change-Id: I90380b027cade633088099ae766ff5c116014cea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the create_table we changed in #844 is also used by the op.create_table() op where we don't have a reflected table to work with so the check we added must be made more specific still.
The text was updated successfully, but these errors were encountered: