-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To check if batch is closed if you need to return a pointer to the type the wrong code is generated #1959
Comments
flymedllva
added
bug
Something isn't working
triage
New issues that hasn't been reviewed
labels
Nov 19, 2022
flymedllva
added a commit
to flymedllva/sqlc
that referenced
this issue
Nov 19, 2022
flymedllva
added a commit
to flymedllva/sqlc
that referenced
this issue
Nov 19, 2022
Nothing really wrong in the original PR, it's just that the |
It certainly is a regression though,it probably means we moved "old" code to a new place. |
This flag was also for v4. Generally, with this flag there is an error in codogeneration |
would be great to merge this :) |
flymedllva
added a commit
to flymedllva/sqlc
that referenced
this issue
Feb 14, 2023
flymedllva
added a commit
to flymedllva/sqlc
that referenced
this issue
Feb 14, 2023
kyleconroy
added
📚 postgresql
🔧 golang
pgx/v4
pgx/v5
and removed
triage
New issues that hasn't been reviewed
labels
Feb 22, 2023
flymedllva
added a commit
to flymedllva/sqlc
that referenced
this issue
Feb 22, 2023
flymedllva
added a commit
to flymedllva/sqlc
that referenced
this issue
Feb 22, 2023
kyleconroy
pushed a commit
that referenced
this issue
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v1.16.0
or 3623ec8, versionv1.15.0
has the correct behavior, since there is no batch closeness checkWhat happened?
To check if batch is closed if you need to return a pointer to the type the wrong code is generated
SQL queries
Configuration
What operating system are you using?
macOS
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go
The text was updated successfully, but these errors were encountered: