Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlc.arg(key) in subquery is not replaced with placeholder #2403

Closed
nobuyo opened this issue Jul 5, 2023 · 0 comments · Fixed by #2414
Closed

sqlc.arg(key) in subquery is not replaced with placeholder #2403

nobuyo opened this issue Jul 5, 2023 · 0 comments · Fixed by #2414
Assignees
@andrewmbenton
Labels
📚 mysql bug Something isn't working 💻 linux 🔧 golang
Milestone
v1.19.1

Comments

@nobuyo
Copy link

nobuyo commented Jul 5, 2023 •
edited
Loading

Version

1.18.0

What happened?

When generating query.sql.go, if there is a subquery in the query and one arg is used multiple times, the sqlc.arg in subquery is not expanded to a placeholder.

I've attached the playground url, thanks!

Relevant log output

No response

Database schema

No response

SQL queries

No response

Configuration

No response

Playground URL

https://play.sqlc.dev/p/4db6630bb57b14ff1913c150a2c0140e9eb4e587f54e93586f430e99681ae83b

Edit: add outer parenthesis to subquery, then it works.

https://play.sqlc.dev/p/8f4de494021b1db7476e47349f46a8d773575ef495399a5af5441cde3e9b41ae

What operating system are you using?

Linux

What database engines are you using?

MySQL

What type of code are you generating?

Go
@nobuyo nobuyo added bug Something isn't working triage New issues that hasn't been reviewed labels Jul 5, 2023
@kyleconroy kyleconroy added 📚 mysql 🔧 golang 💻 linux and removed triage New issues that hasn't been reviewed labels Jul 6, 2023
orisano added a commit to orisano/sqlc that referenced this issue Jul 7, 2023
@orisano
fix: fix to traverse Sel in ast.In
7a60641 
fix sqlc-dev#2403
@orisano orisano mentioned this issue Jul 7, 2023
Merged
@kyleconroy kyleconroy added this to the v1.19.1 milestone Jul 10, 2023
andrewmbenton pushed a commit that referenced this issue Jul 12, 2023
@orisano
fix: fix to traverse Sel in ast.In (#2414)
156bd6d 
fix #2403
andrewmbenton added a commit that referenced this issue Jul 12, 2023
@andrewmbenton
Add an endtoend test that covers the case referenced in #2403
7686c18
@andrewmbenton andrewmbenton mentioned this issue Jul 12, 2023
Merged
andrewmbenton added a commit that referenced this issue Jul 12, 2023
@andrewmbenton
Add an endtoend test that covers the case referenced in #2403 (#2442)
f5c528f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewmbenton andrewmbenton

Labels
📚 mysql bug Something isn't working 💻 linux 🔧 golang
Projects
None yet
Milestone
v1.19.1
Development

Successfully merging a pull request may close this issue.

fix: fix rewrite to traverse Sel in ast.In orisano/sqlc
3 participants
@kyleconroy @andrewmbenton @nobuyo