Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sqlite) add support for returning #1741

Merged
merged 1 commit into from
Jul 12, 2022
Merged

feat(sqlite) add support for returning #1741

merged 1 commit into from
Jul 12, 2022

Conversation

hakobera
Copy link
Contributor

@hakobera hakobera commented Jul 11, 2022 •
edited
Loading

Implement #1724 .
Support both RETURNING <column, column, ...> and RETURNING *.

  • add returning-clause support for SQLite parser
    • Insert
    • Update
    • Delete
  • add end to end test for SQLite
  • update PostgreSQL end to end test to verify RETURNING * support

@kyleconroy Do you think we should update examples to use RETURNING?

@kyleconroy
Copy link
Collaborator

Let's update the examples in a separate PR

@kyleconroy kyleconroy merged commit 8618c39 into sqlc-dev:main Jul 12, 2022
@hakobera hakobera deleted the feat-sqlite-add-support-for-returning branch July 12, 2022 07:52
jlisthood pushed a commit to jlisthood/sqlc that referenced this pull request Apr 28, 2023
@hakobera @jlisthood
feat(sqlite): Add support for returning (sqlc-dev#1741)
2eb2a1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hakobera @kyleconroy