cmd: Generate packages in parallel #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
commented
Jan 18, 2023
| @@ -44,6 +44,7 @@ func Do(args []string, stdin io.Reader, stdout io.Writer, stderr io.Writer) int | |||
| rootCmd.SetIn(stdin) | |||
| rootCmd.SetOut(stdout) | |||
| rootCmd.SetErr(stderr) | |||
| rootCmd.SilenceErrors = true | |||
There was a problem hiding this comment.
When we moved to RunE, we accidentally added some additional error output. Turning that off for now.
kyleconroy
commented
Jan 18, 2023
Comment on lines
+234
to
+239
| m.Lock() | ||
| for n, source := range files { | ||
| filename := filepath.Join(dir, out, n) | ||
| output[filename] = source | ||
| } | ||
| m.Unlock() |
There was a problem hiding this comment.
Writing to a map isn't threadsafe, so put this in mutex. In the future might just use sync.Map instead.
kyleconroy
commented
Jan 18, 2023
| if failed { | ||
| packageRegion.End() | ||
| errored = true | ||
| break |
There was a problem hiding this comment.
If parsing failed, we'd return early. Instead, return errors from every package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
errgroupto parallelize generating code for each SQL package. For configurations with many packages, this should dramatically speed up generation.