Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Go struct tag parsing #2606

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

josharian
Copy link
Contributor

304ba5d didn't correctly handle struct tags whose
value contained a space. (My fault.)

Use a proper struct tag library with a dedicated parser
that handles all the edge cases. Less code, and better.

304ba5d didn't correctly handle struct tags whose
value contained a space. (My fault.)

Use a proper struct tag library with a dedicated parser
that handles all the edge cases. Less code, and better.
@kyleconroy kyleconroy merged commit 9c58a60 into sqlc-dev:main Aug 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants