Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reword phrase about pgx and multidimensional arrays #2619

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

rollulus
Copy link
Contributor

English is not my native language, so I could be wrong, but my interpretation of the text was that pgx can only do multidimensional arrays, and nothing else. I think that's not right. Hope my commit corrects this.

Thanks for sqlc and best of luck with your company around it.

@andrewmbenton
Copy link
Collaborator

Good catch. I agree that your placement of "only" is much clearer.

But we actually added support for multidimensional arrays with other driver packages (in #2338) and forgot to update this documentation, so the whole sentence can go.

@rollulus
Copy link
Contributor Author

Even better, thanks.

@andrewmbenton andrewmbenton merged commit b19550e into sqlc-dev:main Aug 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants