Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Skip analysis of queries without a name annotation #3072

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

andrewmbenton
Copy link
Collaborator

Our codegen plugins don't produce output for queries that don't have an annotation like -- name: Foo :one, but sqlc still does a full query analysis. This change aborts the analysis for any query without an annotation.

The actual change is small, but a fair amount of test output had to be updated.

@kyleconroy kyleconroy merged commit f0184bc into main Dec 20, 2023
8 checks passed
@kyleconroy kyleconroy deleted the andrew/skip-un-annotated-queries branch December 20, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants