Fixes MySQL copyfrom generation with 1 arg stucts #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
approved these changes
Jun 15, 2024
lisitsky
pushed a commit
to lisitsky/sqlc
that referenced
this pull request
Jun 21, 2024
* Updated MySQL copyfrom template to handle strucs with 1 argument * Added copyfrom 1 arg struct testcase * Fixed issue where copyfrom structs were not being emitted * Added testcase to catch not emitting structs used with copyfrom
|
Would it be possible to create a new release so we can make use of this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3443
The copyfrom template generates syntactically incorrect Go when
query_parameter_limitis set to 0.There was a similar bug where by when
query_parameter_limitwas set to 4 but the number of copyfrom parameters was 2, the struct referenced was not being emitted.