compiler: Apply rename rules to enum constants #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinburkemeter Can you try out this commit and tell me if it breaks any of your existing code? |
|
guessing you mean "not 100%" |
|
Yep, edited my original comment. |
|
No diff using this commit, though I haven't tried adding the enum rename, let me try that now. |
|
Works perfectly though I had to read the patch contents to figure out the underscore trick. |
|
@kevinburkemeter what value for the rename struct would you have expected instead of |
|
I don't know, ip_protocol.tcp maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure I want to make this change, as it could break existing generated code.
Fixes #522