Change file paths to use an uppercase drive letter when normalized

[mhahn-ts]

When using the extension to lint, it would neglect to use the .sqlfluffignore file in the root of my project. According to the SQLFluff Docs, this is where the file should be placed.

I found that the issue would be resolved if I set the sqlfluff.workingDirectory using a capital C - C:\dev\MyProject. If I used a lowercase c - c:\dev\MyProject - it would not work. While debugging, I noticed that omitting the sqlfluff.workingDirectory or using a variable (such as ${workspaceFolder}) would result in a lowercase c being used as the drive. This aligns with the VS Code API Docs for fspath. It always returns a lowercase drive letter.

[RobertOstermann]

@mhahn-ts Are you using Windows? I didn't think the Windows filesystem was case-sensitive, so not sure why having a lowercase drive would matter?

[mhahn-ts]

@mhahn-ts Are you using Windows? I didn't think the Windows filesystem was case-sensitive, so not sure why having a lowercase drive would matter?

Yes, I'm on Windows. I am able to reproduce with just SQLFluff in the command line. In fact, it seems to treat the entire filepath in a case-sensitive manner.

In my opinion, it's an issue with SQLFluff. I was planning to create an issue in that repo. This is especially true since you cannot specify absolute path in the .sqlfluffignore. You must just give relative path.
But, based on how the extension automatically gets that ${workspaceFolder}, I do think it is still appropriate to fix it here. If SQLFluff requires a case-sensitive matched filepath, we should make sure that the filepath variables are created that way.

I'd be happy to add more comments or throw it behind a config setting if you think that's appropriate, too.

[RobertOstermann]

Interesting, I just assumed it would work with lowercase drive letters. Thanks for looking into this. I don't think it is necessary to put it behind a config setting, your changes should be good. I should have time tonight to get them merged and publish a release with the changes.

[RobertOstermann]

@mhahn-ts This has been released in v2.4.3