Migrate binding priority to int-based system #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more granular prioritization while also being ABI-compatible. See addition to the CHANGELOG for migration steps.
|
I'm very confused by these test failures, |
RBusarow
reviewed
Mar 29, 2024
compiler/src/test/java/com/squareup/anvil/compiler/codegen/ContributesBindingGeneratorTest.kt
Show resolved
Hide resolved
RBusarow
added a commit
that referenced
this pull request
Mar 29, 2024
prompted by #934 (comment) Before this change, `allWarningsAsErrors` defaulted to `false` locally but `true` in CI. We don't really gain anything by ignoring those warnings locally, since the relevant code is so isolated. Note that the public `compileAnvil(...)` function in our test fixtures ([link](https://github.com/square/anvil/blob/a1def6af59ec11b9d92426947f8c833fb27e7bde/compiler-utils/src/testFixtures/java/com/squareup/anvil/compiler/internal/testing/AnvilCompilation.kt#L251)) defaults to `false`, but now our internal `compile(...)` from `TestUtils` now defaults to `true`. That avoids a breaking change.
RBusarow
added a commit
that referenced
this pull request
Mar 29, 2024
prompted by #934 (comment) Before this change, `allWarningsAsErrors` defaulted to `false` locally but `true` in CI. We don't really gain anything by ignoring those warnings locally, since the relevant code is so isolated. Note that the public `compileAnvil(...)` function in our test fixtures ([link](https://github.com/square/anvil/blob/a1def6af59ec11b9d92426947f8c833fb27e7bde/compiler-utils/src/testFixtures/java/com/squareup/anvil/compiler/internal/testing/AnvilCompilation.kt#L251)) defaults to `false`, but now our internal `compile(...)` from `TestUtils` now defaults to `true`. That avoids a breaking change.
…tributesBindingGeneratorTest.kt Co-authored-by: Rick Busarow <[email protected]>
|
Oh oops I committed before I saw you'd pushed new commits |
|
😕 I did? Didn't mean to! |
RBusarow
approved these changes
Mar 29, 2024
RBusarow
added a commit
that referenced
this pull request
Mar 29, 2024
prompted by #934 (comment) Before this change, `allWarningsAsErrors` defaulted to `false` locally but `true` in CI. We don't really gain anything by ignoring those warnings locally, since the relevant code is so isolated. Note that the public `compileAnvil(...)` function in our test fixtures ([link](https://github.com/square/anvil/blob/a1def6af59ec11b9d92426947f8c833fb27e7bde/compiler-utils/src/testFixtures/java/com/squareup/anvil/compiler/internal/testing/AnvilCompilation.kt#L251)) defaults to `false`, but now our internal `compile(...)` from `TestUtils` now defaults to `true`. That avoids a breaking change.
RBusarow
added a commit
that referenced
this pull request
Apr 6, 2024
prompted by #934 (comment) Before this change, `allWarningsAsErrors` defaulted to `false` locally but `true` in CI. We don't really gain anything by ignoring those warnings locally, since the relevant code is so isolated. Note that the public `compileAnvil(...)` function in our test fixtures ([link](https://github.com/square/anvil/blob/a1def6af59ec11b9d92426947f8c833fb27e7bde/compiler-utils/src/testFixtures/java/com/squareup/anvil/compiler/internal/testing/AnvilCompilation.kt#L251)) defaults to `false`, but now our internal `compile(...)` from `TestUtils` now defaults to `true`. That avoids a breaking change.
RBusarow
added a commit
that referenced
this pull request
Apr 9, 2024
The published `AnvilCompilation` logic gets a new `expectExitCode: ExitCode? = null` parameter. If a value is specified, the assertion is done before executing the `block` lambda. In our internal delegating `compile(...)` functions, the parameter becomes non-nullable and defaults to `ExitCode.OK`. This is done in follow-up to [this](#934 (comment)) comment.
RBusarow
added a commit
that referenced
this pull request
Apr 9, 2024
prompted by #934 (comment) Before this change, `allWarningsAsErrors` defaulted to `false` locally but `true` in CI. We don't really gain anything by ignoring those warnings locally, since the relevant code is so isolated. Note that the public `compileAnvil(...)` function in our test fixtures ([link](https://github.com/square/anvil/blob/a1def6af59ec11b9d92426947f8c833fb27e7bde/compiler-utils/src/testFixtures/java/com/squareup/anvil/compiler/internal/testing/AnvilCompilation.kt#L251)) defaults to `false`, but now our internal `compile(...)` from `TestUtils` now defaults to `true`. That avoids a breaking change.
RBusarow
added a commit
that referenced
this pull request
Apr 9, 2024
* Migrate binding priority to int-based system This allows more granular prioritization while also being ABI-compatible. See addition to the CHANGELOG for migration steps. * Dodge -Werror * More dodging * Map name accordingly * Or not * Ok got it * Update compiler/src/test/java/com/squareup/anvil/compiler/codegen/ContributesBindingGeneratorTest.kt Co-authored-by: Rick Busarow <[email protected]> --------- Co-authored-by: Rick Busarow <[email protected]>
RBusarow
added a commit
that referenced
this pull request
Apr 16, 2024
The published `AnvilCompilation` logic gets a new `expectExitCode: ExitCode? = null` parameter. If a value is specified, the assertion is done before executing the `block` lambda. In our internal delegating `compile(...)` functions, the parameter becomes non-nullable and defaults to `ExitCode.OK`. This is done in follow-up to [this](#934 (comment)) comment.
RBusarow
added a commit
that referenced
this pull request
Apr 16, 2024
The published `AnvilCompilation` logic gets a new `expectExitCode: ExitCode? = null` parameter. If a value is specified, the assertion is done before executing the `block` lambda. In our internal delegating `compile(...)` functions, the parameter becomes non-nullable and defaults to `ExitCode.OK`. This is done in follow-up to [this](#934 (comment)) comment.
RBusarow
added a commit
that referenced
this pull request
Apr 16, 2024
The published `AnvilCompilation` logic gets a new `expectExitCode: ExitCode? = null` parameter. If a value is specified, the assertion is done before executing the `block` lambda. In our internal delegating `compile(...)` functions, the parameter becomes non-nullable and defaults to `ExitCode.OK`. This is done in follow-up to [this](#934 (comment)) comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more granular prioritization while also being ABI-compatible. See addition to the CHANGELOG for migration steps.