Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Breakage on Master #105

Closed
jnicholls opened this issue Apr 9, 2020 · 1 comment · Fixed by #106
Closed

Build Breakage on Master #105

jnicholls opened this issue Apr 9, 2020 · 1 comment · Fixed by #106

Comments

@jnicholls
Copy link

@mbyczkowski The latest commit from 2 days ago has broken the master branch. Just wanted to call it to your attention. Thanks.
mbyczkowski added a commit that referenced this issue Apr 12, 2020
@mbyczkowski
Fix docker build after removal of vendored deps
c746960 
I believe the docker build broke after merging #93. This change should
fix #105
@mbyczkowski mbyczkowski mentioned this issue Apr 12, 2020
Merged
@mbyczkowski
Copy link
Contributor

@jnicholls thanks for the report. I think it must have been the removal of the vendored deps that have broke the docker build. I have a PR now with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docker build after removal of vendored deps square/certstrap
2 participants
@jnicholls @mbyczkowski