Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support androidx.appcompat.widget.TooltipPopup as window type #31

Closed
pyricau opened this issue Jan 6, 2022 · 2 comments · Fixed by #35
Closed

Support androidx.appcompat.widget.TooltipPopup as window type #31

pyricau opened this issue Jan 6, 2022 · 2 comments · Fixed by #35

Comments

@pyricau
Copy link
Member

pyricau commented Jan 6, 2022

See #30 (comment) for details

View.windowType should return TOOLTIP if the window was created by androidx.appcompat.widget.TooltipPopup

We need to do this without having a direct bytecode reference to androidx.appcompat.widget.TooltipPopup or adding a transitive dependency, as curtains needs to remain android x free.

@CoXier
Copy link
Contributor

CoXier commented Jan 6, 2022

Actually we can't list all WindowType., because developer can use WindowManager to create window freely.

I am thinking about the real usage of WindowType. Why do we need it ?

pyricau added a commit that referenced this issue Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants