Extract interface for constructs that can hold a TypeSpec and their builders #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drawers
commented
Nov 16, 2023
| package com.squareup.kotlinpoet | ||
|
|
||
| /** A spec which can contain other [TypeSpec] */ | ||
| public interface TypeSpecHolder { |
There was a problem hiding this comment.
Name follows convention in the project OriginatingElementsHolder
There was a problem hiding this comment.
But differs from Annotatable. Honestly I've been mulling this change because I couldn't think of an -able name. Probably should have gone with AnnotationHolder...
|
|
||
| public interface Builder<out T : Builder<T>> { | ||
|
|
||
| public fun addType(typeSpec: TypeSpec): T |
There was a problem hiding this comment.
Because we haven't provided a default implementation for addType, this interface is less like a trait than Documentable and Annotatable.
It also doesn't achieve a mutable property val typeSpecs: MutableList<TypeSpec> like Documentable and Annotatable
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1553